Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replay: avoid copy paste mistake without reading docs #11117

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Aug 16, 2024

Resolves: #11116

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 0:43am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 0:43am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 0:43am

@@ -3,6 +3,7 @@ you can opt out of the default text masking and image blocking by configuring th

```javascript
Sentry.replayIntegration({
// NOTE: This will disable built-in masking. Look at other options opt-in to masking sensitive data
Copy link
Member

@billyvg billyvg Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the second sentence is supposed to mean

Copy link

codecov bot commented Aug 16, 2024

Bundle Report

Changes will increase total bundle size by 37.62kB (0.25%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server 8.28MB 37.62kB ⬆️
sentry-docs-edge-server 254.34kB 3 bytes ⬇️
sentry-docs-client 6.25MB 6 bytes ⬇️

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion lgtm 👍

@bruno-garcia bruno-garcia enabled auto-merge (squash) September 11, 2024 00:26
@bruno-garcia bruno-garcia merged commit cd7ad49 into master Sep 11, 2024
10 checks passed
@bruno-garcia bruno-garcia deleted the bruno-garcia-patch-1 branch September 11, 2024 00:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Default Privacy Configuration so it is more explicit
4 participants